FormidableLabs / spectacle

A React-based library for creating sleek presentations using JSX syntax that gives you the ability to live demo your code.
https://commerce.nearform.com/open-source/spectacle/
MIT License
9.7k stars 690 forks source link

stop using node 16 in pipelines / clear other pipeline warnings #1324

Closed Burnett2k closed 3 months ago

Burnett2k commented 3 months ago

Description

As directed by Cb, we're no longer supporting node16, and will likely not use node matrixes anymore to build / test various node versions.

This pr removes usage of node 16 and matrix, as well as works to clean up some warnings due to using older versions of Github actions such as setup-node and actions/cache etc.

Fixes #1322 & #1323

ci.yml

Before updating ci.yml (lots of warnings):

image

After updating ci.yml (no warnings):

image

create-spectacle.yml

before:

image

after:

image

release.yml

before:

image

after:

release isn't ran until a merge / push is made to master, so I cannot obtain a screenshot of the results without doing some trickery. If needed I can do so, but the changes are essentially the same as the other two files, so seems probably unnecessary.

Type of Change

How Has This Been Tested?

  1. I verified in the pipelines that the pnpm cache path is still retrieved and set correctly, and warnings were removed
  2. I built and ran all the sample applications locally

Checklist: (Feel free to delete this section upon completion)

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 15158c6ca3f35aea22c13ff1101960debb12a4a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spectacle-docs-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 2:44pm