FormidableLabs / spectacle

A React-based library for creating sleek presentations using JSX syntax that gives you the ability to live demo your code.

https://commerce.nearform.com/open-source/spectacle/

MIT License

9.7k stars 690 forks source link

v6 migration #890

Open vincentdesmares opened 4 years ago

vincentdesmares commented 4 years ago

541 # Question

Hi, great job on the v6. It looks like a very nice upgrade. Yet, when I tried to migrate one of my presentation I found some key features were missing:

With the progress now in the template, it's hard to be able to change its color per slide
The fun pacman-style progress is now a simple dot
The "fit" attribute was really a nice addition, from what I see it's not anymore part of the API

Do you have in your plans to add them or should we stay on the old version?

Also, same as the old version, it's still not possible to split slides per file with a "normal" component usage.

This is not working:

import Page1 from './slides/page1'

...

 <Deck theme={theme} template={template} transitionEffect="fade">
   <Page1 />
</Deck>

We have to still use this "way" of including the slide:

   <Deck theme={theme} template={template} transitionEffect="fade">
    {/* Sad hack to be able to split slides per files */}
    {Landing()}

It is a wanted behavior, if not, what I am missing?

Regards.

kale-stew commented 4 years ago

Thank you for opening this issue, @vincentdesmares! You've asked some great questions and given some very helpful feedback, I will address each of your points individually:

I believe you can still override progress styles per slide if you wanted to, using theme objects directly applied to the Slides you want.
I agree that the Pacman-style progress was a very unique and key feature to Spectacle, I am also in favor of bringing it back.
You are correct, Fit is no longer part of the current API as we hoped users might utilize the flex and grid-like styles to achieve a similar look. I can see the argument for reintroducing it though, particularly for larger blocks/titles, and to save you the trouble of a bunch of custom CSS to make it work.
We are still seeing weird behavior with imported slides, this is a known bug that I am working on. I'll be sure to update this issue when that is fixed. I'm sorry for that. 😕

vincentdesmares commented 4 years ago

I believe you can still override progress styles per slide if you wanted to, using theme objects directly applied to the Slides you want. How can I technically do this when the element is not in a slide? (also, in my project, I have one file per slide). If I put on progress in each slide, then I have to hardcode the style to that it fits at the right place in the screen.

Thanks for taking the time to review this issue!

huy-nguyen commented 4 years ago

@kale-stew Can someone who is not a maintainer bring the Pacman-style progress back? I'm not sure how much work or knowledge of the library's internal is needed.

kale-stew commented 4 years ago

Absolutely! I would welcome it.

On May 23, 2020, at 6:42 PM, Huy Nguyen notifications@github.com wrote:

@kale-stew Can someone who is not a maintainer bring the Pacman-style progress back? I'm not sure how much work or knowledge of the library's internal is needed.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.