Feature: Add role name options

FormidableLabs / terraform-aws-serverless

Infrastructure support for Serverless framework apps, done the right way

https://registry.terraform.io/modules/FormidableLabs/serverless/aws

MIT License

144 stars 19 forks source link

Feature: Add role name options #27

Closed ryan-roemer closed 5 years ago

ryan-roemer commented 5 years ago

I'm open for discussion as to whether or not we want this change, or to do it some other way...

Adds role_*_name option to custom name IAM group, policy, etc. to something besides default admin|developer|ci. Fixes #25

/cc @kevinmstephens @ianwsperber @tptee @jasonwilson @jjasonclark @declension

declension commented 5 years ago

Nice! It might be even more useful if a falsey value meant no group was created - for example currently we could happily live without the developer role completely (especially as they're currently identical to ci AIUI), but maybe that's separate to this.

ryan-roemer commented 5 years ago

@declension -- Good point, but I think I might leave the developer and ci groups around. As for policies, the developer one always has to be there because an IAM group admin needs the IAM policies for developer + admin

.... and it is much easier to reason about the state of resources / modules if the extra groups always exist, so nicer for us 😉 , but perhaps something we can deal with more pain in the future for our end users who want less resources...

ryan-roemer commented 5 years ago

Released in https://registry.terraform.io/modules/FormidableLabs/serverless/aws/0.1.1

declension commented 5 years ago

Thanks @ryan-roemer :)