Allow for custom Lambda roles

FormidableLabs / terraform-aws-serverless

Infrastructure support for Serverless framework apps, done the right way

MIT License

144 stars 19 forks source link

Closed tptee closed 5 years ago

tptee commented 5 years ago

Adds a lambda_role_name variable to override the default Serverless-generated Lambda execution role with a custom one. This is useful for:

tweaking the default permissions
avoiding a chicken-or-egg scenario when using the xray or vpc modules (i.e. terraform init failing to attach policies to the Serverless role because the Serverless stack doesn't yet exist)

Link to reference branch to verify here

ryan-roemer commented 5 years ago

Separate thought for here or another potential PR -- would we maybe want to add a flag to add/create all the default/basic lambda execution role stuff you'd normally get out-of-the-box with serverless like you have here https://github.com/FormidableLabs/aws-lambda-serverless-reference/pull/19/files#diff-b89d1f9fe4d022751a376ef53e46021dR14 ?

tptee commented 5 years ago

Updated docs and have a question on the ARN comment! Ticket for creating default role is here: https://github.com/FormidableLabs/terraform-aws-serverless/issues/44

tptee commented 5 years ago

Released as 0.4.0!