search

FormidableLabs / terraform-aws-serverless

Infrastructure support for Serverless framework apps, done the right way
https://registry.terraform.io/modules/FormidableLabs/serverless/aws
MIT License
144 stars 19 forks source link

add permissions so lambda user can teardown lambda cf stack #64

Closed kevinmstephens closed 4 years ago

kevinmstephens commented 4 years ago

I believe that due to some recent serverless changes there are new permissions required for our -admin user to teardown the serverless cf stack.

This PR adds these two permissions.

More detail here: https://github.com/FormidableLabs/aws-lambda-serverless-reference/issues/54

ryan-roemer commented 4 years ago

Have you verified the changes in aws-lambda-serverless-reference? If not, please check out the yarn _dev:on command to switch all module paths to ../terraform-aws-serverless which should be checked out to this branch. (this can be conveniently undone with yarn _dev:off)

Run your aws-lambda-serverless-reference lambda delete command as the appropriate FIRST.LAST-admin user and verify everything works (it deletes things). Then report back here. We'll merge and release, then you can open a PR with updating the version in aws-lambda-serverless-reference

Thanks!

kevinmstephens commented 4 years ago

@ryan-roemer Thanks for the quick review!

I've verified the changes in aws-lambda-serverless-reference.