[WIP] Resurrect victory-cli

FormidableLabs / victory-cli

A tool for generating charts on the command line.

MIT License

310 stars 13 forks source link

[WIP] Resurrect victory-cli #7

Closed kale-stew closed 2 years ago

kale-stew commented 4 years ago

In its current state, this package is not downloadable via any package manager (npx, npm, and yarn all fail to download). This PR addresses the following issues to bring it back to a functional state:

[x] Updated dependencies across the board
[x] Updated usage of the vastly improved (although also, now deprecated) phantom
[ ] Reintroducing Ci
[ ] More things that will crop up, I'm sure

chrisbolin commented 4 years ago

I'd like to suggest that we drop support for PNG and remove all librsvg dependencies. This would do a few things for us...

vastly simplify the installation process
make this a pure JS project
remove the sharpest edge from the project. almost all issues people have with victory-cli are related to this: #1, #2, #4, #5

also, svgs are great! they are supported in all browser and scalable (they are vectors, dangit)!