Add new 404 page with new designs and sidebar

FormidableLabs / victory-docs

Documentation for Victory: A collection of composable React components for building interactive data visualizations

http://formidable.com/open-source/victory

30 stars 64 forks source link

Add new 404 page with new designs and sidebar #656

Closed wgolledge closed 4 years ago

wgolledge commented 4 years ago

Changes

Add the sidebar to the 404 page
Update the 404 page styling in line with Zeplin designs

Outstanding

I'm guessing we might like to change the footer to be rendered under the sidebar at some point?

wgolledge commented 4 years ago

Agree on the sidebar. I added it to the 404 page because I thought it was supposed to be on there based on the designs? Maybe I took them too literally ha.

I think footer below the sidebar would be nice but could go in a separate PR because it applies to /docs as well

BrittanyIRL commented 4 years ago

I think footer below the sidebar would be nice but could go in a separate PR because it applies to /docs as well

I agree separate PR for the footer/sidebar

wgolledge commented 4 years ago

@boygirl could you please confirm whether you'd like the Sidebar on 404 pages? 🙂

boygirl commented 4 years ago

@wgolledge I think we need to keep it since we don't have a top nav on mobile sizes