Refactor sidebar components

[BrittanyIRL]

My goal here was to make this a little easier to read and update to use modern React structure w/ hooks and components.

• Updated partials from class components to functional
• remove unnecessary brackets on simple components
• delete out of date notes
• move early returns to top of components instead of as defaults in ternaries
• refactor table of contents (this is the big chunk) - separating out functionality where i could and updating how the various subsections of the sidebar are getting assembled so that we only have to go to that function once and create an object instead of individual arrays. This section was hard for me to read while updating the styles last month so I'm hoping now it's slightly easier to follow? The visibility of subsections + the data structure make me hesitant to lean too far into a refactor all at once on this.

To test:

• sidebar should function as it previously did (all sections at the top should start collapsed, when a section is selected (besides the intro section) it should expand, the lead section title that is active should show that gray background.
• please also try building this branch locally. i was battling some weird build error that looks like Failed exporting HTML for URL gallery/area-hover-styles (/Users/brittanyfee nstra/repos/victory-docs/src/pages/gallery-item-template): Cannot read property 'filte r' of undefined which seems to have disappeared of its own accord but also i didn't touch anything to do with the gallery? 👀

If you see anything that should be included here let me know, i think i stared at the table of contents stuff too long.

[BrittanyIRL]

(I'll add reviewers to this once i hunt down what's breaking the build. There's something going wrong with the gallery item template - it's trying to filter undefined. I didn't mess with the gallery so i'm just trying to retrace steps to see what went wrong with the update i did do.)

[boygirl]

@BrittanyIRL I'm noticing a few regressions in this branch

• The guides section no longer shows up in the sidebar at all
• search is behaving quite strangely. It looks like it might only be searching props. Even then, there's some additional odd behavior:

[boygirl]

Since you're working with the sidebar, it would be great if you could update the logo while you're at it.

[BrittanyIRL]

@BrittanyIRL I'm noticing a few regressions in this branch

• The guides section no longer shows up in the sidebar at all
• search is behaving quite strangely. It looks like it might only be searching props. Even then, there's some additional odd behavior:

@boygirl - Sorry about that! I had thought the guides/faq weren't supposed to be there anymore since they had been gone as far as I was aware while working on different things here. They should be back. @wgolledge was spot on about the search so that should be working as a mirror to prod now from what I can tell.

I will update the logo separately if that's ok.

could you take a second look when you get time?

[boygirl]

@BrittanyIRL This is looking great. Just one minor change left. Victory Guides should not be a separate url or exist as an element in the sidebar. Currently this page only exists at /guides. Actually, what do you think about nuking that page all together along with the link to /guides from the home page?

[BrittanyIRL]

@BrittanyIRL This is looking great. Just one minor change left. Victory Guides should not be a separate url or exist as an element in the sidebar. Currently this page only exists at /guides. Actually, what do you think about nuking that page all together along with the link to /guides from the home page?

i was confused by this page's existence and had made this task to handle it, so thank you for bringing this up!

I think axing it would be good - it's just an overview of the other content in this section anyway and you can't actually get to it by clicking on the 'guides' section since that's just supposed be an indicator of the nested items.

[BrittanyIRL]

approved pending removal of Victory Guides page from sidebar

It's gone - which honestly i think was a great idea, none of the other sections of the sidebar have an 'index' file with an overview, i think this makes things more consistent.

[boygirl]

@BrittanyIRL great! Please do get rid of the guides link here as well, then:

[BrittanyIRL]

Everything looks great except I seem to be getting the same ... 'filter' of undefined when doing a build 😕

Off the top of my head not sure what the issue might be.

i'm kinda glad that you saw it too, means it's not just my computer having the issue somehow. Since the last 3 builds of this branch remotely have passed i'm going to shelf looking further into the issue to handle it separately.