FormidableLabs / victory-docs

Documentation for Victory: A collection of composable React components for building interactive data visualizations
http://formidable.com/open-source/victory
30 stars 64 forks source link

colors updated for a11y and to match code sample styles to zeplin #660

Closed BrittanyIRL closed 4 years ago

BrittanyIRL commented 4 years ago

Overview

This PR is to update the colors used for code samples and also to clean up theme colors and make sure contrasts are OK for a11y.

<code> styles

This branch:

Screen Shot 2020-02-21 at 11 04 02 AM

vs in Zeplin:

Screen Shot 2020-02-21 at 6 01 24 PM

(mostly it's that teal that's noticeably different).

Theme colors

There's only really one noticeable color change here, and it's on the home page.

This branch:

Screen Shot 2020-02-21 at 11 04 16 AM

Zeplin:

Screen Shot 2020-02-21 at 6 06 47 PM

Palettes for reference

Screen Shot 2020-02-21 at 2 47 14 PM Screen Shot 2020-02-21 at 2 48 22 PM Screen Shot 2020-02-21 at 2 58 16 PM

To Test

boygirl commented 4 years ago

@BrittanyIRL would you mind pulling the build related commits into a separate PR? I want to talk with Joe more about the new syntax highlighting.

BrittanyIRL commented 4 years ago

@BrittanyIRL would you mind pulling the build related commits into a separate PR? I want to talk with Joe more about the new syntax highlighting.

yup, absolutely!

BrittanyIRL commented 4 years ago

@BrittanyIRL would you mind pulling the build related commits into a separate PR? I want to talk with Joe more about the new syntax highlighting.

yup, absolutely!

https://github.com/FormidableLabs/victory-docs/pull/661