Closed BrittanyIRL closed 4 years ago
@BrittanyIRL I noticed that once the footer is scrolled into view, it only scrolls out of view if you are scrolling on the footer. If you mouse up and scroll on the article, the footer remains in view while the article scrolls under it:
Same with trying to scroll the sidebar while the footer is showing
@BrittanyIRL I noticed that once the footer is scrolled into view, it only scrolls out of view if you are scrolling on the footer. If you mouse up and scroll on the article, the footer remains in view while the article scrolls under it:
Same with trying to scroll the sidebar while the footer is showing
yeah i agree that's not sufficient and i will work to fix it. Is the structure right though? Like, is this right if the scroll was fluid and didn't get stuck?
I think so, but after talking with Phil and Joe this past week, I think there are going to be a few changes to how the sidebar works across our docs, so it might be best to hold off on this work until that is finalized.
I think so, but after talking with Phil and Joe this past week, I think there are going to be a few changes to how the sidebar works across our docs, so it might be best to hold off on this work until that is finalized.
Ok sounds good. I'll go ahead and close this PR.
Overview
The sidenav was previously overlapping with the footer but really we want the sidenav to end on top of the footer. Addressing this change forced some structural updates to keep the header and side nav fixed but allow the different scroll for sidenav vs article and footer.
Updates
main
tag to separate html spaces.<main>
is just the nav and the articles we can more readily have the required fixed full100vh
<aside>
when on docs and hide it on other pages. I tried a few ways of doing this and to me this was the most legible for future updates and the least convoluted.Secondary updates to accommodate the switch to keep the sidenav above the footer
365px
not256px
according to zeplin docsTesting
Screen shots