FormidableLabs / victory-docs

Documentation for Victory: A collection of composable React components for building interactive data visualizations
http://formidable.com/open-source/victory
30 stars 64 forks source link

WIP: Restructure page to put sidenav on top of footer #662

Closed BrittanyIRL closed 4 years ago

BrittanyIRL commented 4 years ago

Overview

The sidenav was previously overlapping with the footer but really we want the sidenav to end on top of the footer. Addressing this change forced some structural updates to keep the header and side nav fixed but allow the different scroll for sidenav vs article and footer.

Updates

Secondary updates to accommodate the switch to keep the sidenav above the footer

Testing

Screen shots

sidebarstacked

mobile scroll

boygirl commented 4 years ago

@BrittanyIRL I noticed that once the footer is scrolled into view, it only scrolls out of view if you are scrolling on the footer. If you mouse up and scroll on the article, the footer remains in view while the article scrolls under it:

footer-scroll

Same with trying to scroll the sidebar while the footer is showing

BrittanyIRL commented 4 years ago

@BrittanyIRL I noticed that once the footer is scrolled into view, it only scrolls out of view if you are scrolling on the footer. If you mouse up and scroll on the article, the footer remains in view while the article scrolls under it:

footer-scroll

Same with trying to scroll the sidebar while the footer is showing

yeah i agree that's not sufficient and i will work to fix it. Is the structure right though? Like, is this right if the scroll was fluid and didn't get stuck?

boygirl commented 4 years ago

I think so, but after talking with Phil and Joe this past week, I think there are going to be a few changes to how the sidebar works across our docs, so it might be best to hold off on this work until that is finalized.

BrittanyIRL commented 4 years ago

I think so, but after talking with Phil and Joe this past week, I think there are going to be a few changes to how the sidebar works across our docs, so it might be best to hold off on this work until that is finalized.

Ok sounds good. I'll go ahead and close this PR.