search

FormidableLabs / victory-docs

Documentation for Victory: A collection of composable React components for building interactive data visualizations
http://formidable.com/open-source/victory
30 stars 64 forks source link

Fix for issue #667 #668

Closed Prodigy00 closed 4 years ago

Prodigy00 commented 4 years ago

I created an issue earlier today for issue #667. I discovered the bug while trying out the guide in code sandbox and included a screenshot. This is a fix for the error, with proof. Wrapping the array with with an object literal fixes it.

Screenshot 2020-04-24 at 08 41 35
boygirl commented 4 years ago

@Prodigy00 Thank you for this fix! It looks like some other changes got introduced along with your docs fix. I'm going to close this PR, but I'll make sure the docs error you're seeing is fixed in the rewrite branch I'm about to merge.

Prodigy00 commented 4 years ago

@boygirl must've been my formatter that introduced those changes, not sure. Happy I could help!