search

FormidableLabs / victory-docs

Documentation for Victory: A collection of composable React components for building interactive data visualizations
http://formidable.com/open-source/victory
30 stars 64 forks source link

Add VictoryHistogram Examples #683

Closed NgoKnows closed 4 years ago

NgoKnows commented 4 years ago

This PR adds two <VictoryHistogram /> examples to the gallery.

boygirl commented 4 years ago

@NgoKnows I think these examples are awesome! The histogram with slider example does stand out kind of strangely on the gallery page though. I like that the example has more complicated styling going on than the rest, but it would be nice to have it a bit more cohesive with the rest of this page. I think removing the box shadow and tweaking the colors so that they clash less with the rest of the page would help a lot.

Screen Shot 2020-05-21 at 1 55 46 PM
boygirl commented 4 years ago

@NgoKnows perfect! thanks for the style tweaks. Approved!