search

FormidableLabs / victory-native-xl

A charting library for React Native with a focus on performance and customization.
https://commerce.nearform.com/open-source/victory-native
719 stars 53 forks source link

Following the doc installs package v37 of the package instead of victory-native-xl #419

Closed Maniae closed 12 hours ago

Maniae commented 12 hours ago

Hello, thank you for your work on this great library !

I'm trying to install Victory-Native-XL on a react-native project. Using npm install victory-native (as written in the documentation) picks the 37.3.1 version (tagged as lateston npm).

Expected behavior: [What you expect to happen]

Installs victory-native v40+ (the "skia" version)

Actual behavior: [What actually happens]

Installs victory-native 37.3.1 (the "svg" version, from the victory repository)

Additional Information

I managed to install the right package using npm i victory-native@41.8.0, I don't think this is intended to be necessary though. Am I doing anything wrong or is there an issue with npm version tagging?

keithluchtel commented 12 hours ago

@Maniae thanks for bringing this to our attention. the "old" victory-native should be releasing to the @legacy tag in npm. We will look into what happened.

carbonrobot commented 12 hours ago

@Maniae The tags have been fixed, appreciate the heads up and we will be working on the CI to make sure this doesn't pop up again.