FormidableLabs / victory-uiexplorer-native

A React Native app for iOS and Android that showcases Victory Native components
65 stars 6 forks source link

`react-native run-android` fails: Could not find property 'VICTORY_UIEXPLORER_RELEASE_STORE_FILE' #11

Open jevakallio opened 7 years ago

jevakallio commented 7 years ago

Building and running the app on Android fails, unless the developer has configured the VICTORY_UIEXPLORER_* gradle environment variables. Setting these values should only be a requirement for creating Play Store releases, not for running debug builds.

Build error in question:

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/imransulemanji/src/victory-pkgs/victory-uiexplorer-native/android/app/build.gradle' line: 102

* What went wrong:
A problem occurred evaluating project ':app'.
> Could not find property 'VICTORY_UIEXPLORER_RELEASE_STORE_FILE' on SigningConfig_Decorated{name=release, storeFile=null, storePassword=null, keyAlias=null, keyPassword=null, storeType=null}.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED
jevakallio commented 7 years ago

Temporarily disabled signing store references in config by https://github.com/FormidableLabs/victory-uiexplorer-native/commit/d9c25c45a0f66a2ac6b3183b1dae9582d4e7b5a4 - these need to be re-enabled for app store releases down the line.