search

FormidableLabs / victory

A collection of composable React components for building interactive data visualizations
http://commerce.nearform.com/open-source/victory/
Other
10.86k stars 525 forks source link

Add codesandbox/stackblitz to the examples #2617

Closed salicius closed 4 months ago

salicius commented 1 year ago

Describe the solution you'd like https://formidable.com/open-source/victory/guides/custom-components/

Can you add the link to a codesandbox/stackblitz to edit the examples ?

Additional context In addition, why examples have class components yet ? Could it be possible to have functional components, since they are the ones that are used the most.

jmezzacappa commented 1 year ago

Additional context In addition, why examples have class components yet ? Could it be possible to have functional components, since they are the ones that are used the most.

Just thought this might be worth mentioning: In the official React docs, class components are now under the "Legacy APIs" section.

(If I get time, maybe I can convert a few of the examples and open a PR to see what happens 🙂)

github-actions[bot] commented 4 months ago

This issue is stale because it has been open for 90 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

github-actions[bot] commented 4 months ago

This issue was closed because it has been inactive for 7 days since being marked as stale. Please open a new issue if you believe you are encountering a related problem.