search

FormidableLabs / victory

A collection of composable React components for building interactive data visualizations
http://commerce.nearform.com/open-source/victory/
Other
10.86k stars 525 forks source link

VictoryZoomContainer: Zoom not working in mobile browsers #2657

Open martin-probst opened 9 months ago

martin-probst commented 9 months ago

Describe the bug While panning works fine, zoom does not work in mobile browsers (moving the finger in vertical direction or pinch gesture).

Victory version Victory 36.6.11. This is not about victory native, but about using standard web apps with victory in a mobile environment or as a PWA.

Code Sandbox link https://formidable.com/open-source/victory/guides/brush-and-zoom https://formidable.com/open-source/victory/docs/victory-zoom-container

To Reproduce Steps to reproduce the behavior: Open examples from the documentation like https://formidable.com/open-source/victory/guides/brush-and-zoom or https://formidable.com/open-source/victory/docs/victory-zoom-container in a mobile browser and try to zoom in. Neither moving vertically (scroll) nor pinching on the graph works to zoom into the graph like it does on a desktop browser.

Expected behavior It should be possible to somehow use zoom on mobile browsers as well. Pinching would be ideal, but handling vertical scrolling would work as well

Smartphone:

carbonrobot commented 7 months ago

Hi, we are transitioning all Native development to our new Victory Native XL library which is purpose built for supporting Native. Many of the design decisions we made in this version of Victory is not ideal for Native development.