FormidableLabs / victory

A collection of composable React components for building interactive data visualizations
http://commerce.nearform.com/open-source/victory/
Other
10.98k stars 525 forks source link

Zoom in touch-enabled devices on browser #2763

Closed omid closed 8 months ago

omid commented 8 months ago

Describe the bug Zoom in/out functionality doesn't work on mobile browsers!

Victory version Your version at: https://formidable.com/open-source/victory/docs/victory-zoom-container/

Code Sandbox link Your sample at: https://formidable.com/open-source/victory/docs/victory-zoom-container/

To Reproduce Just open the link above on mobile and try to zoom in!

Expected behavior A solution like Google Maps on a browser on mobiles can be fine, like this (test it on a touch device): https://developers.google.com/maps/documentation/embed/get-started

Smartphone (please complete the following information):

carbonrobot commented 8 months ago

Duplicate of #2640

omid commented 8 months ago

@carbonrobot No, it's not a duplicate. It's NOT about victory native!

carbonrobot commented 8 months ago

In version 36 of victory, both victory and victory-native use the same code base. The code splits at victory-native v40, which uses an entirely new codebase.

omid commented 8 months ago

Thanks @carbonrobot So it means it works in version 36? or it works after 40 in browsers in touch devices?

carbonrobot commented 8 months ago

There are problems with touch devices in the current version of victory. We started redesigning victory for native in a new package and code starting in version 40.

You can follow the progress of the new victory-native here at https://github.com/FormidableLabs/victory-native-xl