search

FormidableLabs / victory

A collection of composable React components for building interactive data visualizations
http://commerce.nearform.com/open-source/victory/
Other
10.97k stars 526 forks source link

refactor victory-portal to remove dependency on react-dom #2870

Closed KenanYusuf closed 4 months ago

KenanYusuf commented 4 months ago

In https://github.com/FormidableLabs/victory/pull/2799 we refactored the victory-portal component from a class component to function. However, during the refactor we unintentionally introduced react-dom as a dependency with the createPortal function, creating a huge increase in bundle size.

This PR uses an alternate approach to portaling.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 10:32am
changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: 7e26e9d5b0a26a080fac5206d3c4827c8f57f839

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR