Closed crcarlo closed 2 months ago
Latest commit: 4a7eaf9eba1e47e31e8dd6e8224263094de6be2a
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
victory | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 5, 2024 8:25am |
Great work! Confirmed fix in preview docs https://victory-pxruumf9s-formidable-labs.vercel.app/open-source/victory/docs/victory-zoom-container
Description
Fixes #2761
Type of Change
Bug fix
How Has This Been Tested?
Verified manually and added unit tests with previously failing example (
"should't change the domain when zooming out with max zoom out with the cursor outside the container boundary"
).With this simple solution if the cursor is outside the chart container it will be considered as if it is at the container edge.
Steps to reproduce the reproduce the unwanted behavior are reported in #2761.
The new behavior can be tested on the local ZoomContainerDemo example.