FormidableLabs / victory

A collection of composable React components for building interactive data visualizations
http://commerce.nearform.com/open-source/victory/
Other
11.02k stars 524 forks source link

Fix zoom out of chart with cursor outside chart container #2893

Closed crcarlo closed 2 months ago

crcarlo commented 2 months ago

Description

Fixes #2761

Type of Change

Bug fix

How Has This Been Tested?

Verified manually and added unit tests with previously failing example ("should't change the domain when zooming out with max zoom out with the cursor outside the container boundary").

With this simple solution if the cursor is outside the chart container it will be considered as if it is at the container edge.

Steps to reproduce the reproduce the unwanted behavior are reported in #2761.

The new behavior can be tested on the local ZoomContainerDemo example.

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 4a7eaf9eba1e47e31e8dd6e8224263094de6be2a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages | Name | Type | | --------------------------- | ----- | | victory-zoom-container | Patch | | victory-create-container | Patch | | victory-native | Patch | | victory | Patch | | victory-area | Patch | | victory-axis | Patch | | victory-bar | Patch | | victory-box-plot | Patch | | victory-brush-container | Patch | | victory-brush-line | Patch | | victory-candlestick | Patch | | victory-canvas | Patch | | victory-chart | Patch | | victory-core | Patch | | victory-cursor-container | Patch | | victory-errorbar | Patch | | victory-group | Patch | | victory-histogram | Patch | | victory-legend | Patch | | victory-line | Patch | | victory-pie | Patch | | victory-polar-axis | Patch | | victory-scatter | Patch | | victory-selection-container | Patch | | victory-shared-events | Patch | | victory-stack | Patch | | victory-tooltip | Patch | | victory-vendor | Patch | | victory-voronoi-container | Patch | | victory-voronoi | Patch | | victory-docs | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 8:25am
carbonrobot commented 2 months ago

Great work! Confirmed fix in preview docs https://victory-pxruumf9s-formidable-labs.vercel.app/open-source/victory/docs/victory-zoom-container