search

FormidableLabs / victory

A collection of composable React components for building interactive data visualizations
http://commerce.nearform.com/open-source/victory/
Other
11.03k stars 524 forks source link

Split storybook stories into individual files #2952

Closed carbonrobot closed 2 weeks ago

carbonrobot commented 2 weeks ago

Split storybook stories into individual files for easier maintenance and faster HMR. Improves the development experience by correct Types and Auto gen controls for props.

Previous format

// victory-area.stories.tsx
// cs2 format
export const Basic : () => 
...
export const Theme: () =>

New format

// victory-charts/victory-area/basic.stories.tsx
// cs3 format
export const Basic : { ...
// victory-charts/victory-area/theme.stories.tsx
// cs3 format
export const Theme: { ...
changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: 25ed241b4f7e43ef744826ee9ea32e9ec04b3d73

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview Nov 7, 2024 9:25pm
nlkluth commented 2 weeks ago

Looks like a few places have control set to "string", but I think it should be "text"

carbonrobot commented 2 weeks ago

Updated the types, fixed warnings, and corrected the VictoryLabel doc which listed props that were not actually defined on VictoryLabelProps.