search

FormidableLabs / victory

A collection of composable React components for building interactive data visualizations
http://commerce.nearform.com/open-source/victory/
Other
11.03k stars 524 forks source link

Refactor prettier formatting to run from root #2959

Closed carbonrobot closed 1 week ago

carbonrobot commented 1 week ago

Modifies the build scripts so formatting must be run from root to leverage the parallel nature of newer versions of prettier. Also enables the --check flag so prettier will throw a non-zero exit code in CI and the build will fail when there are formatting issues.

New tooling such as eslint, jest, and prettier have support for running parallel across monorepos. The overhead of using both wireit parallel and the tools parallel increases the time to run by exhausting resources.

Also removes the format ci job, since formatting is included as part of ESLint's execution, so this was double-running.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview Nov 12, 2024 2:42pm
changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: 0c5496e8594f787d0a60f28e85ab2a3c3317206a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR