Isolate demo project to its own pnpm workspace

FormidableLabs / victory

A collection of composable React components for building interactive data visualizations

http://commerce.nearform.com/open-source/victory/

Other

11.03k stars 524 forks source link

Isolate demo project to its own pnpm workspace #2976

Closed carbonrobot closed 4 days ago

carbonrobot commented 4 days ago

Isolate demo project to its own pnpm workspace and fix the TS build errors.

Uses Vite as the demo server and hot reload
Moves all the dependencies to the new workspace and out of root
Updates all the imports to reference victory (this creates some duplicates, but we are eventually migrating all these files so this is ok for now)
Modifies the start command to separate running and package watch mode.

// start demo and watch demo files only
$ pnpm start

// start demo and watch packages and demo files
$ pnpm start:dev

vercel[bot] commented 4 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
victory	✅ Ready (Inspect)	Visit Preview	Nov 18, 2024 8:50pm

changeset-bot[bot] commented 4 days ago

⚠️ No Changeset found

Latest commit: 28d39b1d819ab49447b8e02d6fcf502e903c284c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR