Closed SoxPan closed 3 years ago
Update: Nevermind, I misread the issue. We're investigating 😛
Confirmed. At least in webpack5 there's some incorrect interplay with webpack.ProgressPlugin
reporting more status after hooks.done
fires. Debug logs for our repo dev command yarn dev
:
TODO webpack.ProgressPlugin status: 'Compiling', percent: 0.95, msg: 'emitting'
TODO webpack.ProgressPlugin status: 'Compiling', percent: 0.98, msg: 'emitting'
TODO webpack.ProgressPlugin status: 'Compiling', percent: 0.98, msg: 'emitting'
TODO webpack.ProgressPlugin status: 'Compiling', percent: 0.99, msg: 'done'
TODO webpack.ProgressPlugin status: 'Compiling', percent: 0.99, msg: 'done'
TODO hook.done status: 'Success'
# ... webpack stuff snipped ...
TODO webpack.ProgressPlugin status: 'Compiling', percent: 0.99, msg: 'done'
TODO webpack.ProgressPlugin status: 'Compiling', percent: 0.99, msg: ''
TODO webpack.ProgressPlugin status: 'Compiling', percent: 0.99, msg: 'cache'
TODO webpack.ProgressPlugin status: 'Compiling', percent: 0.99, msg: 'cache'
TODO webpack.ProgressPlugin status: 'Compiling', percent: 0.99, msg: 'cache'
TODO webpack.ProgressPlugin status: 'Compiling', percent: 0.99, msg: 'cache'
TODO webpack.ProgressPlugin status: 'Compiling', percent: 1, msg: ''
We can probably use some threshold of percent
and/or just straight msg
to special case not having ProgressPlugin
overwrite a Success
(or possibly other) status.
Progress is 100% but status is still Compiling
If the issue is visual, please provide screenshots here
====================================================================
Steps to reproduce the problem
Just running
webpack-dashboard --minimal -- webpack --config webpack.config.js
commandPlease provide a gist of relevant files
More Details
echo $TERM
? xterm-256color