search

FormingWorlds / JANUS

1-D prescribed atmosphere model of planetary atmospheres that makes use of the SOCRATES radiative transfer code.
https://fwl-janus.readthedocs.io
Apache License 2.0
1 stars 0 forks source link

Consistent atmosphere model output format #42

Closed nichollsh closed 3 months ago

nichollsh commented 7 months ago

The atmosphere modules write NetCDF files containing data such as temperature, pressure, fluxes, and composition. This should be generalised such that they use the same variable names and array shapes. The variables should also use the same units.

At the moment, there are some inconsistencies in model output formats. It is also frequently changing, which makes it difficult to parse old model outputs without writing a new script specifically for each file.

We should think carefully about this, because such a format should allow for future flexibility while preventing inconsistencies.

This is also applies generally (see Issues FormingWorlds/PROTEUS#71, FormingWorlds/PROTEUS#70).

timlichtenberg commented 5 months ago

Come back to this issues once FormingWorlds/PROTEUS#100 and input configuration is fixed.

nichollsh commented 4 months ago

Transferred this from PROTEUS to JANUS, since it's specific to this module. We should aim to have the JANUS NetCDF output variables match those inside the files produced by AGNI. This means that outputs from either model can be read in a consistent manner, and would enable some analysis from PROTEUS (such as emission spectrum plots).

JANUS: https://github.com/FormingWorlds/JANUS/blob/f53287a04f991eb3a3b12f3adb7a4a983466f8d0/src/janus/utils/atmosphere_column.py#L350

AGNI: https://github.com/nichollsh/AGNI/blob/37c532320c4671e33385c4b13761e71aef231d06/src/dump.jl#L72