FormingWorlds / PROTEUS

Coupled atmosphere-interior framework to simulate the temporal evolution of rocky planets.
https://fwl-proteus.readthedocs.io
Apache License 2.0
11 stars 1 forks source link

MORS updates and minor fixes #101

Closed nichollsh closed 3 months ago

nichollsh commented 3 months ago

Spectral synthesis is now included in MORS. This previously duplicated code, but with these changes PROTEUS no longer does any of the per-band synthesis, and it's entirely handled by MORS.

There's still code relating to the Baraffe evolution tracks in PROTEUS, which will need to be moved somewhere eventually. I have decided to leave this for now.

Also updated the default cfg file, and some minor fixes to the AGNI wrapper.

lsoucasse commented 3 months ago

Hi @nichollsh,

This work sounds great. It is important to update Proteus with new Mors and it lightens the "utils" script which aligns with our development goals.

I have two questions for you:

nichollsh commented 3 months ago

Thanks @lsoucasse.

I had been working on the assumption that the Baraffe tracks will be dealt with at a later date, and this is to just get Mors working under the recent changes. We could certainly move the tracks into Mors, or maybe even make a separate small module/package for them. I am leaning towards the second possibility.

I am not seeing any differences between the two init_coupler.cfg files in e7e162e.

lsoucasse commented 3 months ago

Thanks @lsoucasse.

I had been working on the assumption that the Baraffe tracks will be dealt with at a later date, and this is to just get Mors working under the recent changes. We could certainly move the tracks into Mors, or maybe even make a separate small module/package for them. I am leaning towards the second possibility.

I am not seeing any differences between the two init_coupler.cfg files in e7e162e.

OK, the two files are indeed the same, I was miscomparing. We need to avoid duplicating this file in future work.