FormingWorlds / PROTEUS

Coupled atmosphere-interior framework to simulate the temporal evolution of rocky planets.
https://fwl-proteus.readthedocs.io
Apache License 2.0
12 stars 1 forks source link

Fix for volatile pressure and element conservation issues #40

Closed nichollsh closed 1 year ago

nichollsh commented 1 year ago

Previously, the partial pressures of volatiles were being passed to SPIDER at runtime, but the values being passed were not updated based on the previous iteration. This was found to be causing issues with element conservation, and not allowing partial pressures to evolve appropriately over time.

This patch resolves #37 by updating the values of *_init_atmos_pressure from the most recent helpfile entry just before SPIDER is called in RunSPIDER().

I have run PROTEUS with and without this patch in order to validate the changes (discussed on Discord).

This pull request also includes a very minor change to the plotting code.