FormingWorlds / PROTEUS

Coupled atmosphere-interior framework to simulate the temporal evolution of rocky planets.
https://proteus-code.readthedocs.io
Apache License 2.0
10 stars 1 forks source link

Extend MORS sub-module #68

Closed nichollsh closed 3 weeks ago

nichollsh commented 4 months ago

We are currently pulling MORS from Colin's repository on GitHub as a submodule. As part of the effort to remove dependence on external GitHub repositories, I've forked this into a new repository within the FW organisation: https://github.com/FormingWorlds/MORS.

Since this now gives us the opportunity to modify and maintain the code, I also propose the following...

timlichtenberg commented 3 months ago

How far do you think did the last commit to the main branch go with this @nichollsh?

nichollsh commented 3 months ago

I haven't yet attempted to do either of the bullet points listed above. MORS has been moved into a FW repository, and PROTEUS now pulls that, but the module itself is untouched.

nichollsh commented 3 months ago

I am actually wondering if we do not need MORS at all. We can probably use the Baraffe stellar evolution tracks to obtain Teff, log(g), and mass. This can then be used to get the appropriate spectrum from the PHOENIX database.

If we also wanted XUV flux as scalar values, these could be easily obtained from the PHOENIX spectra.

Just an idea.

timlichtenberg commented 1 month ago

Renamed to clarify updated status of the MORS module.

nichollsh commented 3 weeks ago

I do not think that this PHOENIX scaling idea is the way forward. Someone already explored this and found that scaling the spectrum works well. This should then also be an issue in MORS rather than PROTEUS, since that is the module which will require modifications.

Closing this and opening a new issue in MORS.