search

FormularSumo / Galaxy-Collection

A remake of the discontinued Star Wars Force Collection game https://play.google.com/store/apps/details?id=com.formularsumo.starwarsforcecollectionremake.embed
https://formularsumo.github.io/Galaxy-Collection-Web/
GNU Affero General Public License v3.0
6 stars 0 forks source link

Fix middle (?) cards in deck sometimes not moving up #109

Closed FormularSumo closed 2 months ago

FormularSumo commented 2 months ago

image image

This happens in 0.11 as well so not a new issues (edit: doesn't happen in 0.10, presumably because of the movement rewrite in 0.11)

FormularSumo commented 2 months ago

image In Mos Eisley

FormularSumo commented 2 months ago

image Having player 1 cards print their deck number + row at the beginning of every movement phrase, but disabled for any cards not in row 3. The card which is not moving up (first screenshots) is not having its number decremented nor its row.

FormularSumo commented 2 months ago

image Output doing same as above, but printing initial number+row in card followed by number+row in GameState:MoveUp() function before movement occurs. There seems to be a disagreement, where GameState is somehow interpreting 9 3 and 14 2 :thinking:

FormularSumo commented 2 months ago

image So the issue doesn't happen if I disable the code that updates the numbers/rows. Probably because it's live modifying a table while iterating over it, not sure why I thought that was a good idea.