ForrestKnight / yt-dislikes

Add the dislike count back to my YouTube videos via a comment containing that information.
https://youtu.be/1uAH93tzfQY
MIT License
155 stars 13 forks source link

Style improvements #2

Closed trag1c closed 1 year ago

trag1c commented 2 years ago
ForrestKnight commented 2 years ago

Thanks for contributing! I'll test this out on Monday - don't have time to this weekend. And what's funny is that the YouTube Data API documentation used camelCase in all of their Python examples, so I didn't even think to question it - not that I would've, being a Java dev and all lol.

tauraamui commented 2 years ago

Thanks for contributing! I'll test this out on Monday - don't have time to this weekend. And what's funny is that the YouTube Data API documentation used camelCase in all of their Python examples, so I didn't even think to question it - not that I would've, being a Java dev and all lol.

I just twigged too late that this PR already made changes to text original, using f string for expression insertions etc., it's basically the same, however, if you have ( ) params with a string on each newline, without being comma delimited as well, you don't need to call .join on it, the concatenation is automatic. I'm off to bed, but maybe update this PR if you want with the same changes, and delete my PR :). idk

trag1c commented 2 years ago

if you have ( ) params with a string on each newline, without being comma delimited as well, you don't need to call .join on it, the concatenation is automatic

I'm aware of this but thought that not including \n in the strings and using str.join instead would look slightly nicer :)