Added OnSlashCharge handler

ForsakenNGS / DruidMacroHelper

MIT License

15 stars 11 forks source link

Added OnSlashCharge handler #12

Closed HxxxxxS closed 2 years ago

HxxxxxS commented 2 years ago

OnSlashCharge handler will set autoUnshift to 0 if we are out of range of Feral Charge, or Feral Charge is on cooldown.

This lets us Feral Charge from any form.
Especially useful for PvP.
The command takes a unit as a parameter.
API method IsSpellInRange takes spell name as parameter, so i included localization for Feral Charge spell for all localizations.

HxxxxxS commented 2 years ago

Oh and yeah you use it like this

#showtooltip
/dmh charge
/use [noform:1] Dire Bear Form
/cast Feral Charge
/dmh end

or specify unit

#showtooltip
/dmh charge mouseover
/use [noform:1] Dire Bear Form
/cast [@mouseover] Feral Charge
/dmh end

Thaodan commented 2 years ago

Any you smash some of the commits together? Also the merge commit can be removed.

ForsakenNGS commented 2 years ago

Already merged by another pull request and tested/fixed by me today. It still feels a bit off sometimes and is not a 1 button press charge (if that is even possible). Suggestions/PRs are welcome to improve the current state.