FortAwesome / Font-Awesome

The iconic SVG, font, and CSS toolkit
https://fontawesome.com
Other
73.7k stars 12.19k forks source link

Font with weight 900 should be called black and not solid #16885

Open Fale opened 4 years ago

Fale commented 4 years ago

Describe the bug Font weight 900 is called solid.

To Reproduce Look the file name in otfs/ folder

Expected behavior Font weight 900 should be called black as for https://www.w3.org/TR/css-fonts-4/#font-weight-numeric-values

Version and implementation Version: current master

Bug report checklist

tagliala commented 4 years ago

Hi!

Thanks for being part of the Font Awesome Community.

Is this causing some side effects?

We also have 400 called regular instead of normal

Fale commented 4 years ago

Hi,

The reason is that we need to patch this kind of stuff when packaging it for Fedora (and surely other distros).

Best

tagliala commented 4 years ago

Thanks.

Could you please clarify further?

Fale commented 4 years ago

While I was packaging it for Fedora, I had to work around the 900 and not the others, probably because normal for 400 is somehow managed by Linux. To make it work "as expected", I found myself compiling this: https://src.fedoraproject.org/rpms/fontawesome-fonts/blob/18a566dc88883e9837ba3679fd4093795c47ab98/f/fontawesome-fonts-fontconfig.conf (more specifically lines 26 to 39).

tagliala commented 4 years ago

Grazie @Fale

I think that your solution is the way to go for this use case. Since the configuration file you provided instructs the machine on how to handle otf files, I would preserve the current names. Font Awesome 5 Free-Solid-900.otf is in my opinion much clearer for the end user than Font Awesome 5 Free-Black-900.otf.

Anyway, those are just my thoughts, let's ask @robmadole how to proceed