search

FortAwesome / Font-Awesome

The iconic SVG, font, and CSS toolkit
https://fontawesome.com
Other
73.62k stars 12.19k forks source link

Missing attribution in downloaded .svg files #18269

Open notaprofi opened 3 years ago

notaprofi commented 3 years ago

Hi!

When I try to download an svg it says: You must give appropriate credit, provide a link to the license, and indicate if changes were made. You may do so in any reasonable manner, but not in any way that suggests the licensor endorses you or your use. https://fontawesome.com/v5.15/icons/angle-left?style=solid

on the other hand the lisense itself says: you shouldn't need to do anything additional when using these files normally. https://fontawesome.com/license/free

I checked the downloaded svg file and there is nothing which looks like lisence <svg aria-hidden="true" focusable="false" data-prefix="fas" data-icon="angle-left" class="svg-inline--fa fa-angle-left fa-w-8" role="img" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 256 512"><path fill="currentColor" d="M31.7 239l136-136c9.4-9.4 24.6-9.4 33.9 0l22.6 22.6c9.4 9.4 9.4 24.6 0 33.9L127.9 256l96.4 96.4c9.4 9.4 9.4 24.6 0 33.9L201.7 409c-9.4 9.4-24.6 9.4-33.9 0l-136-136c-9.5-9.4-9.5-24.6-.1-34z"></path></svg>

I.e. in one place, it is said that I need to provide a link and in the other place it says that I must not do anything. Also, there is nothing, which defines what "reasonable manner" is. I am inexperienced with laws so I have no idea what is reasonable and what is not, I don't even know who has to be able to see this link, my website users, or developers, or admin only. I don't know how often and easy it must be to find this link for those people.

I would like to know exactly what do I need to do when I'm using free svgs of your font?

Also is everything I can get from your website w/o buying pro plan falling into a category of free icons? P.S. I saw this discussion https://github.com/FortAwesome/Font-Awesome/issues/17891#issuecomment-840013194

tagliala commented 3 years ago

Hi!

Thanks for being part of the Font Awesome Community.

This issue has been fixed in 5.15 in the repo and in the packages (#15580), but apparently this is still an issue when you download icons from the docs

For the moment, you can copy the attribution comment from here: https://github.com/FortAwesome/Font-Awesome/blob/master/svgs/solid/address-card.svg?short_path=ae88c2f

<!-- Font Awesome Free 5.15.4 by @fontawesome - https://fontawesome.com License - https://fontawesome.com/license/free (Icons: CC BY 4.0, Fonts: SIL OFL 1.1, Code: MIT License) -->

Assigning both @robmadole and @talbs

jonom commented 1 year ago

Sorry if this is hijacking an issue, but there are no attributions rendered when using the react library either, so I'm wondering, like @notaprofi, exactly how attribution should be done. It would be nice to have really clear examples of this on the license page.

I noticed there is an attribution.js file that appears to run after npm install, so it feels like it wouldn't be a lot of work to render an HTML comment with the same contents within each SVG automatically. Would you like a PR for that?

Alternatively, if this problem needs to be solved in user land, would it be sufficient to call that function once in an SPA so that the attribution gets logged to the console? Or write a single HTML comment to the page with the same contents, to cover all free icons?