Bug: 6.7.0 "ReferenceError: Can't find variable: X" Desktop Safari

FortAwesome / Font-Awesome

The iconic SVG, font, and CSS toolkit

https://fontawesome.com

Other

73.93k stars 12.2k forks source link

Bug: 6.7.0 "ReferenceError: Can't find variable: X" Desktop Safari #20424

Open 8bitmatt opened 2 days ago

8bitmatt commented 2 days ago

Bug description

Seems to affect all versions of Safari before 18

Error is shown in console "ReferenceError: Can't find variable: X"
- Line of code throwing the error is in pro.min.js
  a=X[e][t];
No icons load for that browser

Reproducible test case

Should be able to use any kit with 6.7.0 and see the error

Screenshots

No response

Font Awesome version

v6.7.0

Serving

Kit

Implementation

CSS

Browser and Operating System

Older versions of Desktop Safari (pre v18)

Web bug report checklist

[X] I have included a test case because my odds go way up that the team can fix this when I do
[X] I have searched for existing issues and to the best of my knowledge this is not a duplicate

johnnorris commented 2 days ago

I'm also having this problem. No icons showing at all for Safari users, on a wide range of versions (13-17 at least). Rollbar is reporting that this is also on iOS. Started on the 18th. I can't see evidence of a release of Font Awesome that might have brought this on - what's going on? [Update] Ah no your website says 11th November, but Github says 18th November, so it's release 6.7.0 for sure.

robmadole commented 2 days ago

@johnnorris @8bitmatt can you send an email (ask for Rob) to hello@fontawesome.com with your Kit tokens? I need to see how those are configured because I have a hunch what's going on here.

rix1 commented 2 days ago

Experienced the same problem. Pinned our version to 6.6.0 in the fontawesome console for now. Let me know if there's anything we can share to help debugging @robmadole 👍

ViktorPontinen commented 1 day ago

Same issue here. But whole page is just blank (probably just implementation), with reported error in console. Pinned to v6.6.0 for, will see if it resolves it.

EDIT: Pinning to 6.6.0 fixed it. So definitely something with v6.7.0 or later.

robmadole commented 1 day ago

Update for those interested. It looks like the minifier we are using for some of the JavaScript files went haywire/has a bug. I was able to fix a customer's Kit by switching to the unminified version. I don't have a root cause fix yet but we're working on it.