Open SylvainCorlay opened 9 years ago
+1 nice!
Well drawn @SylvainCorlay , these look slick! :+1:
+1. How does step-in/out look like with only 3 lines ?
@Carreau Here are the 3-lines versions of step-into and step-out:
Icon name | Proposal |
---|---|
fa-step-into | |
fa-step-out |
but those are only 4 line high instead of 5 (like step over). I prefer them all equal overall height.
but those are only 4 line high instead of 5 (like step over). I prefer them all equal overall height.
You also need to think if they are next to each other in a button group horizontally. Having the 3 lines aligned across button make more sens (IMHO).
@Carreau good point. Would be useful to see them all arranged horizontally and pick the combo which is most visually pleasing.
Here is the Spyder debug toolbar with the font-awesome theme and those icons:
PS: I am aware of the vertical alignment issue of the play-pause icon. I need to adjust the font bearing for this one which is also not a font-awesome icon.
After seeing that, I think I favor the idea of @Carreau to have 3-line step-in and step-out buttons so that the content lines will align horizontally.
👍
:+1: I also favor the idea of three lines aligned horizontally, would probably be more pleasing... i.e.
+1 to this and also to @Carreau idea about using only 3 lines.
Is it possible to have the arrow head of fa-step-out a bit further on the left ? This way it would be more obvious that the debug is going out of the bloc. Same goes for fa-step-into, the start of the arrow should be shorter. In both cases the point is that the arrow itself should show that the start and end point are at different alignment.
+1
The latest screenshot of Spyder implementing the suggestions above:
@SylvainCorlay lgtm!
Not my suggestion... :( Here is what I meant: It doesn't looks as good as I wished on the second one, and I cut too much on the first one, but you get the idea.
+1 to latest icons
+1
+1
This is a quick update to let folks know that we’re refining our icon request workflow behind the scenes, and as part of that we’re going through all open requests and filing them into several new buckets to be addressed.
In this case we’ve added this issue to our new list to be created! We can’t promise any firm timelines right now, but this will help us keep track of it.
We’ll update this issue when the icon is released into the wild 🙂
I have svg and glyph versions of those if you are willing to use this design. (They should be pixel perfect at 14px lie font-awesome icons). I would be happy to contribute the font file.