FortAwesome / angular-fontawesome

Official Angular component for Font Awesome 5+
https://fontawesome.com
MIT License
1.49k stars 152 forks source link

Feature request: Versioning follow angular major versions #282

Closed bovandersteene closed 4 years ago

bovandersteene commented 4 years ago

Describe the problem you'd like to see solved or task you'd like to see made easier

It would be easier if the package follow the major angular version for version support:

f.e.

So we don't need to search in the release notes, but we can see it immediately if we look at the package.json file

Feature request checklist

devoto13 commented 4 years ago

Thanks for the suggestion. I see how this may be useful. The only concern I have is as to what happens if we need to release another major release outside of Angular lifecycle. We'll consider doing this when we're ready to release a stable 1.0.0.

There is another open issue regarding the confusing versioning: #263. I'll close this one to keep discussion in one place. Please add a comment to #263 if you have any other thoughts.

In the meantime you can prominently see the compatibility in the README, we announce such changes in the release notes as you've mentioned (I believe people read them before updating 😄) and also consumers will get a peer dependency warning if they install a wrong version.