FortAwesome / angular-fontawesome

Official Angular component for Font Awesome 5+
https://fontawesome.com
MIT License
1.49k stars 152 forks source link

Feature request: Add input to set position of fa-layers-counter (fa-layers-bottom-left, etc) #309

Closed nelson6e65 closed 2 years ago

nelson6e65 commented 3 years ago

Describe the problem you'd like to see solved or task you'd like to see made easier

There is an option to set the position of counter by using fa-layers-bottom-left, fa-layers-bottom-right, fa-layers-top-left and fa-layers-top-right (https://fontawesome.com/v5.15/how-to-use/on-the-web/styling/layering) but I did not found it documented in this lib.

Is this in relation to an existing part of angular-fontawesome or something new?

Missing prop of fa-layers-counter.

What is 1 thing that we can do when building this feature that will guarantee that it is awesome?

Add an input for position

Why would other angular-fontawesome users care about this?

Set position of counter.

On a scale of 1 (sometime in the future) to 10 (absolutely right now), how soon would you recommend we make this feature?

9.6

Feature request checklist

nelson6e65 commented 3 years ago

I was able to use [classes]="['fa-layers-bottom-left']", but should be nice to have an input.

devoto13 commented 3 years ago

If you feel like it, please send a PR šŸ˜„

You can find some information on how to modify the library in our developer documentation.

nelson6e65 commented 3 years ago

I'll try this weekend. šŸ˜ƒ

NayeBeckham commented 2 years ago

Hello, I would like to contribute. Can I create a PR to solve the issue? Thank you!

devoto13 commented 2 years ago

@NayeBeckham PR is more than welcome :)

You would need to do something similar to size input of FaLayersComponent and implement a corresponding test case similar to this test. Please refer to the developer documentation to get started.