search

FortAwesome / angular-fontawesome

Official Angular component for Font Awesome 5+
https://fontawesome.com
MIT License
1.49k stars 152 forks source link

v6 readme update #336

Closed ej2 closed 2 years ago

devoto13 commented 2 years ago

Thanks for the PR, but we actually support v5 or newer, so the current text saying 5+ is correct.

devoto13 commented 2 years ago

Also any particular reason to change the contributors section?

ej2 commented 2 years ago

Also any particular reason to change the contributors section?

This is prep work for the release of Font Awesome version 6 coming in Feb 2022.

devoto13 commented 2 years ago

Hey @ej2, Thanks for the PR, but it has been hanging for a while and I still don't quite understand what problem does it aim to solve. So I'm going to close it as stale.

I've changed how do we link to the Font Awesome team in the Contributors section in https://github.com/FortAwesome/angular-fontawesome/pull/347 as it seems that should simplify the maintenance a bit. Let me know if you think that there is another issue that needs to be addressed.