Closed mwaibel-go closed 1 year ago
Close because I didn’t pay attention and the repro doesn’t actually reproduce the issue.
This still happens. When using npm workspaces, I use npm install --install-strategy=nested
so that each workspace's dependencies are placed in the same level as the workspace. This causes npm to place fontawesome-common-types under fontawesome-svg-code only.
@Nosfistis I suggest you open a new issue with a repro to get clear of my noise
Describe the problem
When compiling my application, I get this error:
What did you expect?
No compilation error; or
@fortawsome/angular-fontawesome
listing@fortawesome/fontawesome-common-types
as peer dependency.Reproducible test case
https://stackblitz.com/edit/angular-ivy-y53r3l?file=package.json
I bumped the versions of
@fortawesome/angular-fontawesome
and@fortawesome/fontawesome-svg-core
to 6.4.2 and removed the ‘regular’ and ‘brands’ icon packages