search

FortAwesome / angular-fontawesome

Official Angular component for Font Awesome 5+
https://fontawesome.com
MIT License
1.49k stars 152 forks source link

Support Angular 17 #416

Closed SupremeVoid closed 1 year ago

SupremeVoid commented 1 year ago

Support Angular 17.

Peer Dependencies in package.json currently requires Angular 16.

devoto13 commented 1 year ago

Will cut a release later today.

SupremeVoid commented 1 year ago

I wanted to open a pull request (updating all dev-/dependencies) but there are problems with the eslint configuration. Something broke the configuration.

 0:0  error  Parsing error: ESLint was configured to run on `<tsconfigRootDir>/projects/demo/src/environments/environment.prod.ts` using `parserOptions.project`:
- <tsconfigRootDir>/projects/demo/tsconfig.app.json
- <tsconfigRootDir>/projects/demo/tsconfig.spec.json
- <tsconfigRootDir>/projects/demo/e2e/tsconfig.json
However, none of those TSConfigs include this file. Either:
- Change ESLint's list of included files to not include this file
- Change one of those TSConfigs to include this file
- Create a new TSConfig that includes this file and include it in your parserOptions.project
See the typescript-eslint docs for more info: https://typescript-eslint.io/linting/troubleshooting#i-get-errors-telling-me-eslint-was-configured-to-run--however-that-tsconfig-does-not--none-of-those-tsconfigs-include-this-file
devoto13 commented 1 year ago

Yeah, turns out it is a bit more involved than just updating the dependencies 🙃