Linking custom addon, which uses ember-fontawesome, in app fails to build.

FortAwesome / ember-fontawesome

Font Awesome Ember component using SVG with JS

https://fontawesome.com

MIT License

119 stars 49 forks source link

Linking custom addon, which uses ember-fontawesome, in app fails to build. #106

Open teejayhh opened 5 years ago

teejayhh commented 5 years ago

I have the following setup. Ember cli 3.5

Made an addon (SampleAddon) which uses the font-awesome package.
Made an app (SampleApp) which also uses the font-awesome package
followed the addon usage instructions and added font-lib and fontawesome package the the dependency section.
yarn link (in SampleAddon)
yarn link 'SampleAddon' (in SampleApp)
start up the app (SampleApp) server

💥

Build Error (broccoli-fontawesome-pack: free-regular-svg-icons)
Cannot find module '@fortawesome/free-regular-svg-icons'

Could someone please verify this or has come across this as well.

Best regards Thomas

teejayhh commented 5 years ago

Ok I found the issue, if your app uses @fortawesome/free-regular-svg-icons and your addon doesn't, then you will get this issue.

jrjohnson commented 5 years ago

@teejayhh thanks for the report. This may be an issue with yarn link. Unlike npm link yarn doens't install new dependencies when it is linked. So adding @fortawesome/free-regular-svg-icons do the addon dependencies will only work when that addon is installed into the app with npm add.

To work around this in the past I've pushed the addon branch up to github and then used something like yarn add username/repo#branch-name to install it into my app for testing.

jnkroeker commented 5 years ago

seeing the same issue usingnpm link