Fix for FA5, update app to ember 4.12 & add tests for ember versions

FortAwesome / ember-fontawesome

Font Awesome Ember component using SVG with JS

https://fontawesome.com

MIT License

119 stars 49 forks source link

Fix for FA5, update app to ember 4.12 & add tests for ember versions #233

Closed mkszepp closed 1 year ago

mkszepp commented 1 year ago

fix #230 (support for FA5)
add tests for FA5
update to ember 4.12

mkszepp commented 1 year ago

@robmadole i have readded some code from 0.4.2 into the v1.x (which was removed). With this change, we can use also FA5 with v1.0. For FA6 there is no difference after this changes

In additional i have added a test for FA5, so we don't run into any bug with FA5.

Hopfully we can get this fix ❤️

mkszepp commented 1 year ago

@jrjohnson i have created to PR #234 (update ember) & #235 (fix for FA5, which has also the changes of ember update)