FortAwesome / ember-fontawesome

Font Awesome Ember component using SVG with JS
https://fontawesome.com
MIT License
119 stars 49 forks source link

Update addon to ember 4.12 #234

Closed mkszepp closed 1 year ago

mkszepp commented 1 year ago
mkszepp commented 1 year ago

@jrjohnson while i have tested the switch from npm to pnpm i have found out, that the addons is using array-unique, but the dependency of that is missing. It was only working, because other packages were bringing this package.

Now i have added in the dependency.

mkszepp commented 1 year ago

@jrjohnson thanks for merging the fix for FA5, i have now also resolved all merge conflicts for this update, so we can also merge this one, after the release of the fix in v1

mkszepp commented 1 year ago

seen, that there is again a merge conflicts.

idk why this was updated in release commit (https://github.com/FortAwesome/ember-fontawesome/commit/e3533bafb0ad5ec615eb9b5917b24c85e9d01089#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R104): https://github.com/FortAwesome/ember-fontawesome/blob/e3533bafb0ad5ec615eb9b5917b24c85e9d01089/package.json#L104

@jrjohnson now we can merge this PR

jrjohnson commented 1 year ago

Thanks so much for getting all of this done @mkszepp, I really appreciate all the work you put in! I'm back from vacation and I merged this and requested a 2.0.0 release from the FA team. I also pinged them about the weird ember-source change in the last release.

jrjohnson commented 1 year ago

Really appreciate all of your work on this @mkszepp, 2.0.0 was release today!

mkszepp commented 1 year ago

@jrjohnson thanks 4 release! ❤️