FortAwesome / ember-fontawesome

Font Awesome Ember component using SVG with JS
https://fontawesome.com
MIT License
119 stars 49 forks source link

Is there anyway to exclude the js file from the bundle? #52

Open NullVoxPopuli opened 6 years ago

NullVoxPopuli commented 6 years ago

I'm looking at broccoli-concat-analyser, and see:

image

it's in tiny text on the right. what's the js for? can I remove it somehow?

robmadole commented 6 years ago

Are you talking about the fontawesome.js? The 7.87 KB entry?

NullVoxPopuli commented 6 years ago

Yeah, that one :)

On Wed, Jun 27, 2018, 4:18 PM Rob Madole notifications@github.com wrote:

Are you talking about the fontawesome.js? The 7.87 KB entry?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/FortAwesome/ember-fontawesome/issues/52#issuecomment-400815280, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMJamHT6b3PaMy2fiZ6FDMPe6TZJNgqks5uA-ihgaJpZM4U334r .

robmadole commented 6 years ago

Are you pre-rendering the icons @NullVoxPopuli ? I'm a little confused as to the question here. Aren't you using ember-fontawesome? If so then, that's just the JS that goes with it. (I feel like I'm missing something here ;)

NullVoxPopuli commented 6 years ago

Yeah, ember-fontawesome https://gitlab.com/NullVoxPopuli/emberclear/blob/master/packages/frontend/package.json#L39

I'm both prerendering (prember) and not prerendering (non-prember pages), but I was hoping that the fa icon helper could be replaced by i tags at build time, ya know? Just so there is no runtime evaluation / rendering of the helper (so, the Js then wouldn't be required :) )

jrjohnson commented 6 years ago

@NullVoxPopuli it sounds doable to have a configuration option to only allow build time rendering and never include the component or any of the backing JS from fontawesome. I'm not volunteering mind you :)

hoIIer commented 4 years ago

any movement on this?

jrjohnson commented 4 years ago

@burritoIand not yet. If you're interested in getting involved and helping jump into #e-fontawesome in discord and let's chat.