FortAwesome / ember-fontawesome

Font Awesome Ember component using SVG with JS
https://fontawesome.com
MIT License
119 stars 49 forks source link

Warning messages due simple-html-tokenizer version #75

Open ldalves opened 6 years ago

ldalves commented 6 years ago

After I installed @fortawesome/ember-fontawesome, I started getting some warning messages when running ember s.

# ember s
WARNING:
WARNING: /myapp/node_modules/simple-html-tokenizer/commands:
WARNING:    Missing package directory

These warnings were fixed in https://github.com/tildeio/simple-html-tokenizer/pull/61.

However it seems that ember-fontawesome still uses old version of simple-html-tokenizer.

# npm ls simple-html-tokenizer
myapp@0.0.0 /myapp
+-- @fortawesome/ember-fontawesome@0.1.7
| `-- ember-ast-helpers@0.3.5
|   +-- @glimmer/compiler@0.27.0
|   | `-- simple-html-tokenizer@0.3.0
|   `-- @glimmer/syntax@0.27.0
|     `-- simple-html-tokenizer@0.3.0  deduped
`-- ember-cli-template-lint@1.0.0-beta.2
  `-- ember-template-lint@1.0.0-beta.5
    `-- @glimmer/compiler@0.36.2
      `-- @glimmer/syntax@0.36.2
        `-- simple-html-tokenizer@0.5.6

Is there anything we could do in order to avoid those warnings?

hoIIer commented 6 years ago

I just added this to get around it until ember-ast-helpers is updated in this:

  "resolutions": {
    "@fortawesome/ember-fontawesome/**/ember-ast-helpers": "^0.4.0"
  }
robmadole commented 5 years ago

Attempted to upgrade in #81 but either I did something silly/dumb or there is a dependency issue.

If anyone wants to give this a look that would be helpful. I don't have time right now to run the issue to ground but I'll try next week.

jrjohnson commented 5 years ago

This is a known issue with ember-ast-helpers: https://github.com/cibernox/ember-ast-helpers/issues/21