FortAwesome / fa-icon-chooser

an icon chooser implemented as a web component
MIT License
15 stars 6 forks source link

Overhaul for kit-only configuration and svg-only rendering within the chooser #16

Closed mlwilkerson closed 3 years ago

mlwilkerson commented 3 years ago

This PR covers a couple of significant changes:

  1. to improve rendering performance, no more relying on the FA SVG/JS autoReplaceSvg and mutation observer functionality. Instead, there's a new fa-icon that directly renders an SVG.

  2. drop support for inheriting any of four technologies: KitSvg, KitWebfont, CdnSvg, CdnWebfont. Now, we'll just always use SVG tech within the chooser. If the outer DOM already has the svg API setup, we'll use it, otherwise we'll add it for use in the DOM.

  3. do not rely directly on Pro SVG kits to fetch in the SVGs, but instead fetch them as needed, adding them the library for possible subsequent re-use.