FortAwesome / font-awesome-sass

Font-Awesome Sass gem for use in Ruby/Rails projects
MIT License
906 stars 265 forks source link

Missing documentation about removal of font-awesome-sprockets #207

Open dacook opened 2 years ago

dacook commented 2 years ago

In the upgrade from 5 to 6, I found that this import fails:

 @import 'font-awesome-sprockets';

The FA 5 readme says it's required, but the FA 6 readme omits it, so presumably it's no longer required.

As you can see on the above links, there used to be a second with details about upgrading, but it's been removed in favour of linking to the main Font Awesome upgrade guides.

I suggest an upgrade tip should be mentioned on the readme to save time for other people upgrading.

ecpantalone commented 1 year ago

I suggest an upgrade tip should be mentioned on the readme to save time for other people upgrading.

glad I found this. yes please add it to the readme

alecarneiro1993 commented 1 year ago

Indeed. After removing font-awesome-sprockets, everything started to work again. Glad I found this

ericdfields commented 1 year ago

Thank you! I've never added a fork with a branch to a Gemfile before. The syntax if needed is

gem 'resque-web', require: 'resque_web', git: 'https://github.com/EdCordata/resque-web', branch: 'fix/file-to-import-not-found-or-unreadable-font-awesome-sprockets'
masatokawano commented 2 months ago

Thank you. This helps.