search

FortAwesome / react-fontawesome

Font Awesome React component
https://fontawesome.com
MIT License
3.68k stars 264 forks source link

Add titleId to TypeScript typings #471

Closed rpokorny closed 2 years ago

rpokorny commented 2 years ago

I'm trying to use FontAwesomeIcon with Server Side Rendering, and ran into the issue with the autogenerated ids on svg <title> elements failing to match between client and server. It appears there's already a titleId prop that has been added to solve this, but it seems to be missing from the Typescript typings. This PR adds it. As far as I could see there were no automated tests for the typescript typings or any other additional things that I should update, but let me know if I missed something.

rpokorny commented 2 years ago

Whoops this is a dupe of https://github.com/FortAwesome/react-fontawesome/pull/406