search

FortAwesome / react-fontawesome

Font Awesome React component
https://fontawesome.com
MIT License
3.67k stars 262 forks source link

Bug - fix a few animations #516

Closed jasonlundien closed 2 years ago

jasonlundien commented 2 years ago

This PR fixes animations that were NOT working: beatFade, flip, spinPulse, and spinReverse.

Reviewer: @robmadole -- Will you review for accuracy of code?

Dependencies: none, but was brought up in a Help Scout ticket

Tests Added yes, also added tests for fixes.

robmadole commented 2 years ago

@jasonlundien do we need a test for spinPulse and spinReverse?

robmadole commented 2 years ago

Also, we probably need to update the TypeScript .d.ts file too with the changes.

jasonlundien commented 2 years ago

@robmadole -- I did NOT include those (spinPulse and spinReverse ) because the beatFade was of the same format. When looking at the test file, FontAwesomeIcon.test.js, I noticed we were NOT testing each animation. If you would like, or prefer, I can create a test for each one including spinPulse and spinReverse ?

Update: looks like besides spinPulse and spinReverse, we are missing beat and fade. I will go ahead and make tests for all of those then.

robmadole commented 2 years ago

@jasonlundien yeah let's add some tests for all of those. It might be overkill but we've missed a few of these types of things recently (and by "we" I mean "me" ;) so it would be good to add those please. Thank you, sir.