Closed jasonlundien closed 2 years ago
@jasonlundien do we need a test for spinPulse
and spinReverse
?
Also, we probably need to update the TypeScript .d.ts file too with the changes.
@robmadole -- I did NOT include those (spinPulse
and spinReverse
) because the beatFade
was of the same format. When looking at the test file, FontAwesomeIcon.test.js
, I noticed we were NOT testing each animation. If you would like, or prefer, I can create a test for each one including spinPulse
and spinReverse
?
Update: looks like besides spinPulse
and spinReverse
, we are missing beat
and fade
. I will go ahead and make tests for all of those then.
@jasonlundien yeah let's add some tests for all of those. It might be overkill but we've missed a few of these types of things recently (and by "we" I mean "me" ;) so it would be good to add those please. Thank you, sir.
This PR fixes animations that were NOT working: beatFade, flip, spinPulse, and spinReverse.
Reviewer: @robmadole -- Will you review for accuracy of code?
Dependencies: none, but was brought up in a Help Scout ticket
Tests Added yes, also added tests for fixes.