search

FortAwesome / react-fontawesome

Font Awesome React component
https://fontawesome.com
MIT License
3.67k stars 262 forks source link

Not compatible with Jest ESM #555

Open jasperlin451 opened 8 months ago

jasperlin451 commented 8 months ago

Describe the bug

When trying to upgrade my project to be fully ESM, I run into 

    SyntaxError: The requested module '@fortawesome/react-fontawesome' does not provide an export named 'FontAwesomeIcon'

This should be fixable by updating the following lines: https://github.com/FortAwesome/react-fontawesome/blob/976c1adc59934b34e52b11c03dda4bd69831a6df/package.json#L5-L7

to use the modern Node.js packaging standard.

{
  "type": "module",
  "exports": {
    "import": "./index.es.js",
    "require": "./index.js"
  }
}
dhwang commented 5 months ago

@jasperlin451 Maybe create a PR for "This should be fixable by updating the following lines:" ?