Closed mmaloon closed 2 months ago
Didn't realize there is already a pull-request discussing this issue: https://github.com/FortAwesome/react-fontawesome/pull/559
Regardless of any PRs, this issue should exist.
The usage of .split()
function contradicts TS typing of className
props which is nullable:
Thanks, I'll take a look at this.
Just released 0.2.2. Please give this a try.
Describe the bug Release 0.2.1 introduces bug where explicitly passing
undefined
as a className causes an errorReproducible test case Codepen Demo
Expected behavior This has potential to break existing code. Maybe revert and save for a major release?
This code works for version 0.2.0 but not on 0.2.1
<FontAwesomeIcon className={undefined} icon={faUser} />